This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Limit the number of PVF workers #4273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In particular, limit the number of preparation workers to 1 (soft & hard) and limit the number of execution workers to 2. The reason why we are doing this is that it seems many workers launched at the same time can cause problems. I.e. if there are more than 2 preparation workers, the time for preparation rises significantly to the point of reaching the timeout. This was mostly observed with parallel_compilation=true, so each worker used `numcpu` threads and now we are looking to flip that parameter to `false`. That said, we want to err on the safe side here and gradually enable it later if our measurements show that we can do that safely.
pepyakin
added
A0-please_review
rphmeier
approved these changes
Nov 12, 2021
drahnr
pushed a commit
that referenced
this pull request
Nov 15, 2021
* Limit the number of PVF workers In particular, limit the number of preparation workers to 1 (soft & hard) and limit the number of execution workers to 2. The reason why we are doing this is that it seems many workers launched at the same time can cause problems. I.e. if there are more than 2 preparation workers, the time for preparation rises significantly to the point of reaching the timeout. This was mostly observed with parallel_compilation=true, so each worker used `numcpu` threads and now we are looking to flip that parameter to `false`. That said, we want to err on the safe side here and gradually enable it later if our measurements show that we can do that safely. * Adjust the test to accomodate the changed config value
23 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In particular, limit the number of preparation workers to 1 (soft &
hard) and limit the number of execution workers to 2.
The reason why we are doing this is that it seems many workers launched
at the same time can cause problems. I.e. if there are more than 2
preparation workers, the time for preparation rises significantly to the
point of reaching the timeout.
This was mostly observed with parallel_compilation=true, so each worker
used
numcputhreads and now we are looking to flip that parameter tofalse. That said, we want to err on the safe side here and graduallyenable it later if our measurements show that we can do that safely.