Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ops: alphanet enhancements #765

Merged
merged 11 commits into from Mar 27, 2019
Merged

ops: alphanet enhancements #765

merged 11 commits into from Mar 27, 2019

Conversation

azban
Copy link
Contributor

@azban azban commented Mar 23, 2019

  • adds support for passing image to local alphanet script
  • uses nearprotocol docker image
  • adds logging + waiting spinner to announce readiness

MaksymZavershynskyi
MaksymZavershynskyi approved these changes Mar 25, 2019
View reviewed changes
Copy link
Contributor

@MaksymZavershynskyi MaksymZavershynskyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, in the future we would want to be able to send RPC requests to different local nodes. Therefore we should either bind them to different host ports and listen to the same RPC 3030 internally, or bind and listen to different RPC ports.

@azban azban merged commit b904d94 into master Mar 27, 2019
@ilblackdragon ilblackdragon added this to the AlphaNet milestone Mar 28, 2019
@azban azban deleted the ops-alphanet-enhancements branch March 29, 2019 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaksymZavershynskyi MaksymZavershynskyi MaksymZavershynskyi approved these changes

Assignees

@ilblackdragon ilblackdragon

@MaksymZavershynskyi MaksymZavershynskyi

Labels
None yet
Projects
None yet
Milestone
AlphaNet
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@azban @MaksymZavershynskyi @ilblackdragon