Put logic in place for transactions view #2260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We can cleanup the minus signs in a later PR |
nholland94
approved these changes
Apr 19, 2019
There was a problem hiding this comment.
Approving as we will land this as is for now, but when we move forward to fully style this component, I think we will need to switch to CSS Grid. Flexbox is no good here due to the complex alignment across multiple sections of elements in the dom, and tables are basically the C++ of CSS (footguns galore).
Logic in place for rendering all transactions in the spec. Some layout is completed, but styling still needs a ton of work. Tables were used as this is semantically a table, but it's unclear whether it should just all be flex or not.
bkase
force-pushed
the
transactions-view-logic
branch
from
5593e0f
to
d812e1a
Compare
bkase
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Logic in place for rendering all transactions in the spec.
Some layout is completed, but styling still needs a ton of work.
Tables were used as this is semantically a table, but it's unclear
whether it should just all be flex or not.
TransactionsViewfor now just hardcodes all the cells present inthe mockup to make sure we can look at all of them (for the
purposes of testing).
The Spec (non-expanded)
The Implementation (non-expanded)
The Spec (expanded)
The Implementation (expanded)