Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set up CI with Azure Pipelines #2744

Merged
merged 11 commits into from May 9, 2019
Merged

Set up CI with Azure Pipelines #2744

merged 11 commits into from May 9, 2019

Conversation

quentinlesceller
Copy link
Member

@quentinlesceller quentinlesceller commented Apr 10, 2019 •
edited

Replace #2742 and fix #2691.

While GitLab is a great candidate for CI, it does not support macOS and Windows builds with the SaaS solution.

This PR adds Azure Pipelines as Grin CI.

Pros:

Cons:

  • No caching yet (but it is in the pipeline).
  • Microsoft.
  • Documentation scattered and not always super clear.

To do:
Complete release process with Azure Pipelines.

Example of build process here:

If you don't like the facts that there is 12 tasks running on GitHub I can always let it display as one task.

If this is accepted next steps would be to:

ignopeverell
ignopeverell approved these changes Apr 11, 2019
View reviewed changes
Copy link
Contributor

@ignopeverell ignopeverell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've got nothing against the Microsoft of the last 5 years and this looks very nice indeed, especially being able to do CI across all the platforms we support. Ping me to enable on our repo, I assume I need an Azure account?

@quentinlesceller
Copy link
Member Author

I guess you need to create an Azure account. I'll let you know when to merge I'm trying to do the GitHub release process and once that is done we'll be able to merge.

@ignopeverell
Copy link
Contributor

Where are we at with Azure CI? This PR needs some minor conflict fix.

@quentinlesceller
Copy link
Member Author

quentinlesceller commented Apr 15, 2019 •
edited

@ignopeverell as you can see I needed some cleanup #2752., in order to fix Windows CI Test on Azure Pipeline CI. You can follow my progress on GitHub and on Azure. Windows tests are still not passing but I'm making very good progress.
Fixing the merge conflict btw.

@quentinlesceller quentinlesceller mentioned this pull request Apr 15, 2019
Closed
2 tasks
@quentinlesceller
Copy link
Member Author

quentinlesceller commented May 2, 2019 •
edited

Okay this is done here is an example of what a release looks like: https://github.com/quentinlesceller/grin/releases.
The changelog is not as nice though (but it still can be generated manually if needed).
@ignopeverell I'll need the name of the connection and I'll update the yml file.
Once this is done we can merge and proceed to a test beta release @yeastplume.
IMO we should keep Travis file around in case we want to switch back (but just disable the check).

@quentinlesceller quentinlesceller merged commit 567ed95 into mimblewimble:master May 9, 2019
@antiochp antiochp added this to the 1.1.0 milestone Jun 5, 2019
@quentinlesceller quentinlesceller deleted the azure-pipelines branch June 11, 2019 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antiochp antiochp antiochp left review comments

@ignopeverell ignopeverell ignopeverell approved these changes

@garyyu garyyu Awaiting requested review from garyyu

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.

Investigate alternatives to TravisCI
3 participants
@quentinlesceller @ignopeverell @antiochp