Improve the parallel scan latency #2201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkase
reviewed
Apr 10, 2019
| root_at_depth = 0 then there would be just one block with all the leaves in | ||
| it. No of blocks = 2^root_at_depth. This function returns the starting | ||
| position of the block containing pos *) | ||
| let block_of state pos = |
There was a problem hiding this comment.
you could make a pretty easy unit test for this, may as well (especially since you're about to refactor stuff)
bkase
approved these changes
Apr 10, 2019
deepthiskumar
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Halved the parallel scan latency by emitting proofs at depth=1 and not merging up to the root at depth=0.
Added a new field
latency_factorto select the level where we'd want to start emitting the proofs and stop merging. Increasing the latency factor (>=2) (or reducing the latency) reduces the work capacity of the tree. Currently the latency_factor is set to 1 but this can be tuned based on based on how fast/slow snark work is done.Checklist: