Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wallet API delete transaction method #603

Closed
iscander01 opened this issue Apr 11, 2019 · 4 comments
Closed

Wallet API delete transaction method #603

iscander01 opened this issue Apr 11, 2019 · 4 comments
Assignees
Labels
api Issues related to Wallet API enhancement New feature or request

Comments

@iscander01
Copy link
Collaborator

Please add method to wallet API to delete the transaction.

@gingervik gingervik added this to To do in Wallet API 2 via automation Apr 11, 2019
@gingervik gingervik removed this from To do in Wallet API 2 Apr 11, 2019
@nesbox nesbox added api Issues related to Wallet API enhancement New feature or request labels Apr 11, 2019
@nesbox nesbox added this to To do in Wallet API 3 via automation Apr 11, 2019
@nesbox nesbox moved this from To do to In progress in Wallet API 3 Apr 11, 2019
nesbox added a commit that referenced this issue Apr 11, 2019
@nesbox nesbox moved this from In progress to Done in Wallet API 3 Apr 11, 2019
@nesbox
Copy link
Contributor

nesbox commented Apr 11, 2019

API docs should be updated after release:

tx_delete

Delete existing transaction, return true if successfully canceled or error with the reason.

-->

{
	"jsonrpc":"2.0", 
	"id": 4,
	"method":"tx_delete", 
	"params":
	{
		"txId" : "a13525181c0d45b0a4c5c1a697c8a7b8"
	}
}

<--

{
	"jsonrpc":"2.0", 
	"id": 4,
	"result": true
}

@gingervik gingervik assigned Sergei-Beam and unassigned nesbox Apr 12, 2019
@Sergei-Beam
Copy link
Member

@nesbox Please forbid to delete transactions which have progress statuses: pending, waiting for receiver/waiting for sender, receiving/sending

@nesbox
Copy link
Contributor

nesbox commented Apr 15, 2019

@nesbox Please forbid to delete transactions which have progress statuses: pending, waiting for receiver/waiting for sender, receiving/sending

fixed

@nesbox nesbox moved this from In progress to Done in Wallet API 3 Apr 15, 2019
@Sergei-Beam Sergei-Beam assigned Sergei-Beam and unassigned nesbox Apr 17, 2019
@Sergei-Beam
Copy link
Member

Checked

Wallet API 3 automation moved this from Done to Tested Apr 17, 2019
roman-strilets pushed a commit that referenced this issue Apr 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issues related to Wallet API enhancement New feature or request
Projects
Wallet API 3
  
Tested
Development

No branches or pull requests

3 participants