Skip to content
This repository has been archived by the owner on Mar 16, 2023. It is now read-only.

Feat protocol audit nik naks #79

Merged
merged 14 commits into from Mar 28, 2019
Merged

Conversation

zac-williamson
Copy link
Collaborator

Problem

Solution

Packages Updated

Checklist

  • Prefix PR title with [WIP] if necessary.
  • Write tests for added code when needed.
  • Update documentation when needed.

renamed `uint` to `uint256`

removed SafeMath when increasing 256-bit loop iterators

smart contract validators now reset free memory pointer after YUL validation code

commented NoteUtils and removed some unneccessary temporary variables
added noteType variable into ABI encoding of notes

updated abiEncoder to encode/decode with noteType

updated JoinSplitABIEncoder to include noteType

updated DividendComputationABIEncoder to include noteType

updated BilateralSwapABIEncoder to include noteType

refactored BilateralSwapABIEncoder to contain 2 proofOutput entries consistent with a swap

added `eslint-import-resolver-lerna` dev-dependency at root level

updated NoteUtils.sol to expect new note format

added `getNoteType` method into NoteUtils.sol

updated computed note hashes to include noteType

changed JOIN_SPLIT_SIGNATURE EIP712 message to contain `bytes32 noteHash` instead of `bytes32[4] note`
…pdated

fixed bug in test script that was preventing profile output from being run

wrote brief gas report
@zac-williamson zac-williamson merged commit 6b88e31 into audit Mar 28, 2019
@ArnSch ArnSch deleted the feat-protocol-audit-nik-naks branch April 5, 2019 12:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant