Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More capability analysis support #427

Merged
merged 17 commits into from Mar 9, 2019
Merged

More capability analysis support #427

merged 17 commits into from Mar 9, 2019

Conversation

bts
Copy link
Contributor

@bts bts commented Mar 7, 2019

  • compose-capability support
  • require-capability support
  • tagging and model output for require-capability calls
  • fix return value tagging for scopes which have zero bindings
  • refactor binding translation to use continuation-passing style

@bts bts added the FV Formal verification label Mar 7, 2019
@bts bts requested a review from joelburget March 7, 2019 22:37
joelburget
joelburget reviewed Mar 7, 2019
View reviewed changes
src/Pact/Analyze/Model/Text.hs
<> "." <> pretty funName <> " with "
<> if length vids > 1 then "arguments" else "argument"
in header : (displayVids showArg ++ [emptyLine])
let withArgs = case length vids of
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside: I've been thinking it would be nice to use Doc instead of Text in this module

@bts bts requested a review from joelburget March 9, 2019 15:42
joelburget
joelburget approved these changes Mar 9, 2019
View reviewed changes
Copy link
Contributor

@joelburget joelburget left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bts bts merged commit 45deba9 into kadena-io:master Mar 9, 2019
@bts bts deleted the analyze-caps branch March 9, 2019 22:51
@LindaOrtega LindaOrtega added the Pact 3.0 Features for next major Pact release label May 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joelburget joelburget joelburget approved these changes

Assignees
No one assigned
Labels
FV Formal verification Pact 3.0 Features for next major Pact release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bts @joelburget @LindaOrtega