Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of using the
Driver
inPpxlib
, usePpx_deriving
. A deriver gets passed a module path and options, and is invoked only when the particularderiving
flag is used. That makes a lot of code we had unnecessary.Small loss:i f a module version name is wrong, like
Vx
instead ofV1
, we don't have the location to highlight in Merlin.I discovered a dune bug others had reported, mentioned in the
dune
for the tests. Added aVERBOSE
flag to the Makefile, allowing confirmation that expected test failures fail for the expected reason.Checklist: