Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use deriver for version ppx #2075

Merged
merged 1 commit into from Mar 29, 2019
Merged

Use deriver for version ppx #2075

merged 1 commit into from Mar 29, 2019

Conversation

psteckler
Copy link
Member

Instead of using the Driver in Ppxlib, use Ppx_deriving. A deriver gets passed a module path and options, and is invoked only when the particular deriving flag is used. That makes a lot of code we had unnecessary.

Small loss:i f a module version name is wrong, like Vx instead of V1, we don't have the location to highlight in Merlin.

I discovered a dune bug others had reported, mentioned in the dune for the tests. Added a VERBOSE flag to the Makefile, allowing confirmation that expected test failures fail for the expected reason.

Checklist:

  • Tests were added for the new behavior
  • All tests pass (CI will check this if you didn't)
  • Serialized types are in stable-versioned modules
  • Does this close issues? List them:

@psteckler psteckler added the ready-to-merge Adding this label will trigger mergify and trigger CI to run and merge the PR label Mar 29, 2019
@mergify mergify bot merged commit 7913882 into master Mar 29, 2019
@mergify mergify bot deleted the feature/version-ppx-deriving branch March 29, 2019 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge Adding this label will trigger mergify and trigger CI to run and merge the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants