Feat/local execution #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marklnichols
approved these changes
Mar 28, 2019
emilypi
approved these changes
Mar 29, 2019
| case r of | ||
| Left e -> liftIO $ putMVar _localResultVar $ Left e | ||
| Right r' -> liftIO $ putMVar _localResultVar r' | ||
| go |
There was a problem hiding this comment.
Ah so it wasn't forming runlooping. Cool 👍
larskuhtz
reviewed
Mar 30, 2019
| @@ -175,7 +175,7 @@ initPactService' ver cid chainwebLogger spv act = do | |||
| let !pd = P.PublicData def (unsafeGetChainId cid) def def | |||
| let !pse = PactServiceEnv Nothing checkpointEnv spv pd | |||
|
|
|||
| evalStateT (runReaderT act pse) theState | |||
| evalStateT (runReaderT act pse) (PactServiceState theState Nothing) | |||
There was a problem hiding this comment.
This uses the lazy state monad. Is this intentional? Could it increase the risk of space leaks?
There was a problem hiding this comment.
@marklnichols any comment here -- both PactService and Chainweb.Pact.Types use lazy state. Was there a reason for this? I'm assuming it was an oversight.
Fixing.
There was a problem hiding this comment.
Great catch @larskuhtz
There was a problem hiding this comment.
Note doing strict state across the board @emmanueldenloye @marklnichols @emilypi .
Also cleaning up some other warnings -- uninitialized variables in tests, and Lars' putLog (underscoring).
larskuhtz
approved these changes
Mar 30, 2019
larskuhtz
reviewed
Mar 30, 2019
| @@ -507,7 +507,7 @@ withElasticsearchBackend mgr esServer ixName inner = do | |||
| , HTTP.requestHeaders = [("content-type", "application/json")] | |||
| } | |||
|
|
|||
| putLog a = HTTP.defaultRequest | |||
| _putLog a = HTTP.defaultRequest | |||
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Done, but currently hanging after the first request ...