Disallow rollbacks on the last step of a pact. #448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sirlensalot
requested changes
Mar 29, 2019
There was a problem hiding this comment.
Looks great! Please add a "bad test" to tests/pact/bad/ and run it here:
Line 27 in 2f45825
sirlensalot
approved these changes
Apr 1, 2019
|
@joelburget this is all good except merge |
bts
added a commit
that referenced
this pull request
Apr 26, 2019
* origin/master: add warning at top (#477) Fix `img` symlinks [skip ci] (#478) Revert "Fix Doc Symlinks (#476)" Fix Doc Symlinks (#476) Add note about bad z3 version to the readme. (#474) JSON serialization of Term/Scope (#473) Non-malleability: signatories and chain version in payload (#470) Shorter hashes (#471) Fix run.sh -- application type with curl, syntax fix, hashes (#472) Better compile errors (#467) links -- downloads, pactlang.org tutorials, pactweb (#468) History persist test (#465) Fixed select to match insert and schema. (#463) PactOutput type for reliable Term output, yields (#460) Remove duplicate definition of `read-cp-master`. (#447) Disallow rollbacks on the last step of a pact. (#448) Tweak order of docs for natives. (#454) Fix pretty-printing of strings (#441)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.