Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use realms shim submodule #110

Merged
merged 3 commits into from Apr 12, 2019
Merged

Use realms shim submodule #110

merged 3 commits into from Apr 12, 2019

Conversation

katelynsills
Copy link
Contributor

No description provided.

@katelynsills katelynsills requested a review from warner April 9, 2019 21:06
erights
erights approved these changes Apr 12, 2019
View reviewed changes
Copy link
Member

@erights erights left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am approving and merging because it seems straightforward. But really, this needs review by @warner . @warner , could you double check post merge? Thanks.

@erights erights merged commit 2defdf1 into master Apr 12, 2019
@katelynsills katelynsills deleted the use-realms-shim-submodule branch April 12, 2019 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erights erights erights approved these changes

@warner warner Awaiting requested review from warner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@katelynsills @erights