Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Testnet stability improvements #90

Merged
merged 13 commits into from Apr 4, 2019
Merged

Testnet stability improvements #90

merged 13 commits into from Apr 4, 2019

Conversation

larskuhtz
Copy link
Contributor

@larskuhtz larskuhtz commented Apr 1, 2019 •
edited

Testnet stability:

  • fix POW miner
  • add an efficient POW miner that avoids memory allocations in the inner loop.
  • bound size of cut-queue

Logging and Debugging

  • add more logging to CutDb (we make it less chatty again once testnet is stable)
  • separate testing and production use in Cut.hs to help with debugging the code in that module.
  • add telemetry for the sizes of various internal queues.
  • make mem-pool less chatty
  • fix some log scope labels
  • log session statistics less often

House Keeping:

  • support recent version of massiv
  • fix TaskQueue unit tests

@larskuhtz larskuhtz force-pushed the lars/tmp branch 7 times, most recently from bc7c4bf to 10127a2 Compare April 3, 2019 20:34
@larskuhtz larskuhtz changed the title [DO NOT MERGE] Testnet stability improvements Apr 3, 2019
@larskuhtz larskuhtz marked this pull request as ready for review April 3, 2019 20:41
fosskers
fosskers suggested changes Apr 3, 2019
View reviewed changes
src/Data/DiGraph/FloydWarshall.hs Show resolved Hide resolved
src/Data/DiGraph/FloydWarshall.hs Show resolved Hide resolved
src/Chainweb/CutDB.hs Outdated Show resolved Hide resolved
@fosskers fosskers mentioned this pull request Apr 3, 2019
Closed
fosskers
fosskers suggested changes Apr 3, 2019
View reviewed changes
scripts/run-nodes.sh Outdated Show resolved Hide resolved
src/Chainweb/CutDB.hs Outdated Show resolved Hide resolved
src/Chainweb/CutDB.hs Show resolved Hide resolved
src/Chainweb/Miner/POW.hs Show resolved Hide resolved
src/Chainweb/Miner/POW.hs Outdated Show resolved Hide resolved
src/Chainweb/Miner/POW.hs Outdated Show resolved Hide resolved
src/Chainweb/Miner/POW.hs Outdated Show resolved Hide resolved
src/Chainweb/Miner/POW.hs Outdated
-- The result is guaranteed to have a valid nonce.
--
mine :: BlockHeader -> Nonce -> IO BlockHeader
mine h nonce = do
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unused?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. Should we delete it and only keep the fast miner? I was wondering if this function may still be useful for testing and debugging.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should just keep the fast miner.

src/Data/DiGraph/FloydWarshall.hs Outdated Show resolved Hide resolved
src/P2P/TaskQueue/Test.hs Outdated Show resolved Hide resolved
@larskuhtz larskuhtz force-pushed the lars/tmp branch 2 times, most recently from 1cfe35e to ce80f40 Compare April 4, 2019 00:17
@larskuhtz larskuhtz merged commit cf8bd05 into master Apr 4, 2019
@fosskers fosskers deleted the lars/tmp branch May 24, 2019 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fosskers fosskers fosskers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@larskuhtz @fosskers