This repository has been archived by the owner on Jun 3, 2020. It is now read-only.
Implement chain-specific keyrings (closes #231, #111) #232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moves from a single global keyring to chain-specific keyrings, where keys/signers can be potentially shared across chains if desired. This enables true multitenancy for supporting multiple chains with a single KMS instance, and reloves lingering questions around the access control model, namely that each connection has an associated chain ID, and signing operations are isolated to that chain's keyring.
|
awesome. save a lot of money for us. |
zmanian
approved these changes
Apr 19, 2019
This was referenced Apr 19, 2019
Merged
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves from a single global keyring to chain-specific keyrings, where keys/signers can be potentially shared across chains if desired.
This enables true multitenancy for supporting multiple chains with a single KMS instance, and resolves lingering questions around the access control model, namely that each connection has an associated chain ID, and signing operations are isolated to that chain's keyring.