twelve words backup screen UI and logic #78
Conversation
| @@ -14,7 +14,7 @@ class KeyGeneratorService { | |||
| const seedAsUint8Array = Buffer.from(seed, 'hex'); | |||
| const left32BitsOfSeed = seedAsUint8Array.slice(0, nacl.sign.seedLength); | |||
| const { publicKey, secretKey } = nacl.sign.keyPair.fromSeed(left32BitsOfSeed); | |||
| return { publicKey: Buffer.from(publicKey).toString('hex'), secretKey: Buffer.from(secretKey).toString('hex'), seed }; | |||
| return { publicKey: Buffer.from(publicKey).toString('hex'), secretKey: Buffer.from(secretKey).toString('hex'), seed, resolvedMnemonic }; | |||
There was a problem hiding this comment.
This will clash with "mnemonic" param in wallet actions.
There was a problem hiding this comment.
you can rename it like this { mnemonic: returnedMnemonic }
There was a problem hiding this comment.
Renaming on destructuring still does not solve the issue. Unless I change the "mnemonic" parmam name in the saveNewWallet fuction to something else, like so:
in keyGenService:
return { publicKey: Buffer.from(publicKey).toString('hex'), secretKey: Buffer.from(secretKey).toString('hex'), seed, mnemonic: resolvedMnemonic };
in wallet actions:
There was a problem hiding this comment.
this works just fine:
What you've done - changed param name in function params destruct without changing param name in all usages of this function => broken app functionality
There was a problem hiding this comment.
OK np, this brings us back to how it was coded to begin with.
There was a problem hiding this comment.
it's not the same, the important thing is not breaking the app with untested changes
IlyaVi
changed the title
In this commit:
Create 12 words backup page. Displaying the words only for now. (no print or copy yet).