Proofs RPC long-polling #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antonlerner
reviewed
Mar 27, 2019
| <-r.closedChan | ||
| } else { | ||
| select { | ||
| case <-r.closedChan: |
There was a problem hiding this comment.
why read from channel here if you have a default statement?
There was a problem hiding this comment.
to check whether closedChan was closed. if so, then it will proceed, instead of the default case, which basically checks if it wasn't closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented long-polling support for
GetMembershipProof&GetProofRPC calls. I didn't use gRPC stream (server side push) because there's only one update, so I thought that long-polling is more appropriate.Server timeouts are not handled at the moment, since they are expected to be very long anyway.