Udp net server and client #704 #741

y0sher · 2019-03-27T23:02:22Z

antonlerner · 2019-03-31T08:46:50Z

p2p/net/udp.go

+
+func (n *UDPNet) Send(to node.Node, data []byte) error {
+	// todo : handle session if not exist
+	addr, err := net.ResolveUDPAddr("udp", to.Address())


why is there a different resolving algorithm for an address? it's a mapping between nodeid -> ip so should it be the same one as in tcp?

There's no difference. this method is called after we've resolved the IP address by the NodeID.
it's just a resolve method of the IP itself. (so hostnames could be used for example). so this just makes the address string we have about this node to a valid golang UDP address struct.

antonlerner · 2019-03-31T08:48:06Z

p2p/net/udp.go

+
+func (n *UDPNet) listenToUDPNetworkMessages(listener net.PacketConn) {
+	for {
+		buf := make([]byte, maxMessageSize) // todo: buffer pool ?


why not create it outside the loop?

antonlerner · 2019-03-31T08:48:41Z

p2p/net/udp.go

+	for {
+		buf := make([]byte, maxMessageSize) // todo: buffer pool ?
+		size, addr, err := listener.ReadFrom(buf)
+		if err != nil {


what happens when there's an error? at least log it

the code below is what happens when there's an error. it's logged as a warning for Temporary error (e.g reading timeout or other udp possible temp errors). an error log is written and the routine is stopped if there's a critical error in the server.

antonlerner · 2019-03-31T08:49:32Z

p2p/net/udp.go

+		// todo : check size?
+		// todo: check if needs session before passing
+
+		go func(msg UDPMessageEvent) {


if reading from buf failed this code will have errors

you mean there will be no errors but buf will be empty or something like that?

antonlerner · 2019-03-31T08:51:19Z

p2p/swarm.go

@@ -105,7 +107,7 @@ func (s *swarm) waitForGossip() error {
 func newSwarm(ctx context.Context, config config.Config, newNode bool, persist bool) (*swarm, error) {

 	port := config.TCPPort
-	address := inet.JoinHostPort("0.0.0.0", strconv.Itoa(port))
+	address := inet.JoinHostPort("127.0.0.1", strconv.Itoa(port))


listening on 127.0.0.1 means you are only listening on loopback internal IF' listening on 0.0.0.0 means you are listening on any IF

antonlerner · 2019-03-31T09:09:17Z

p2p/udp.go

+// todo: no need to return chan, but stay consistent with api
+// RegisterDirectProtocolWithChannel registers a protocol on a channel
+func (mux *UDPMux) RegisterDirectProtocolWithChannel(name string, c chan service.DirectMessage) chan service.DirectMessage {
+	mux.messages[name] = c


If this method can be called at any time by any routine messages needs to be thread safe

this method should be called only right after initialization, before Start. means ProccessDirectProtocolMessage - the routine that reads from the map should never be called concurrently with it.

Add comment about it

antonlerner · 2019-03-31T09:16:14Z

p2p/udp.go

+
+	var data service.Data
+
+	if payload := msg.GetPayload(); payload != nil {


what if it's neither?

these are the only fields we accept as part of this message. if none of them are present it's probably a malformed message. I'll add a treatment for that case.

antonlerner · 2019-03-31T09:22:46Z

p2p/net/udp.go

+		go func(msg UDPMessageEvent) {
+
+			select {
+			case n.msgChan <- msg:


don't quite understand this, lets talk

Block until msgChan has a free slot (buffered chan) or until shutdown.

antonlerner · 2019-03-31T09:36:25Z

p2p/udp.go

+	msgChan := mux.network.IncomingMessages()
+	for {
+		select {
+		case msg, ok := <-msgChan:


this means you are always reading from this channel, when the channel closes, doesn't it return nil to signal it? I'd love to talk about it and see what is the most pragmatic way to do this

do you mean it keeps reading after the channel was closed ? either way, it will only happen once. as we return when that's the case.

antonlerner · 2019-03-31T09:44:17Z

Makefile

@@ -84,7 +84,7 @@ endif
 .PHONY: $(PLATFORMS)

 test:
-	ulimit -n 400; go test -short -p 1 ./...
+	ulimit -n 500; go test -short -p 1 ./...


wont work on mac default terminal

but now we have more file descriptors since we run a udp server.. (especially this is needed in tests)

also seems like it works in my mac default terminal

…m's start sequence

antonlerner reviewed Mar 31, 2019

View reviewed changes

antonlerner approved these changes Mar 31, 2019

View reviewed changes

y0sher added 5 commits March 31, 2019 19:47

udp network interface, udp mux in main pkg next to swarm, add to swar…

f71fc98

…m's start sequence

more tests and some type corrections

644571b

fix some tests

de8472a

cr comments

9454c60

fix fmt

10a6fc4

y0sher force-pushed the udp_net_server branch from 4b09c49 to 10a6fc4 Compare March 31, 2019 16:47

y0sher merged commit c588f90 into develop Mar 31, 2019

y0sher deleted the udp_net_server branch June 25, 2019 07:43

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Udp net server and client #704 #741

Udp net server and client #704 #741

y0sher commented Mar 27, 2019

antonlerner Mar 31, 2019

y0sher Mar 31, 2019

antonlerner Mar 31, 2019

antonlerner Mar 31, 2019 •

edited

y0sher Mar 31, 2019

antonlerner Mar 31, 2019

y0sher Mar 31, 2019

antonlerner Mar 31, 2019

antonlerner Mar 31, 2019

y0sher Mar 31, 2019

antonlerner Mar 31, 2019

antonlerner Mar 31, 2019

y0sher Mar 31, 2019

antonlerner Mar 31, 2019

y0sher Mar 31, 2019

antonlerner Mar 31, 2019 •

edited

y0sher Mar 31, 2019 •

edited

antonlerner Mar 31, 2019

y0sher Mar 31, 2019

y0sher Mar 31, 2019


		var data service.Data

		if payload := msg.GetPayload(); payload != nil {

Navigation Menu

Udp net server and client #704 #741

Udp net server and client #704 #741

Conversation

y0sher commented Mar 27, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

antonlerner Mar 31, 2019 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

antonlerner Mar 31, 2019 • edited

Choose a reason for hiding this comment

y0sher Mar 31, 2019 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

antonlerner Mar 31, 2019 •

edited

antonlerner Mar 31, 2019 •

edited

y0sher Mar 31, 2019 •

edited