Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block oracle improvements #789

Merged
merged 2 commits into from Apr 7, 2019
Merged

Block oracle improvements #789

merged 2 commits into from Apr 7, 2019

Conversation

noamnelke
Copy link
Member

There were a couple of comments in #778 that this fixes.

@noamnelke noamnelke mentioned this pull request Apr 5, 2019
6 tasks
zalmen
zalmen previously requested changes Apr 7, 2019
mesh/activation.go Show resolved Hide resolved
var nodeID, vrfSigner = generateNodeIDAndSigner()

func generateNodeIDAndSigner() (mesh.NodeId, *crypto.VRFSigner) {
publicKey, privateKey, _ := crypto.GenerateVRFKeys()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comment that for each run a different key will be created at the moment

@noamnelke noamnelke dismissed zalmen’s stale review April 7, 2019 10:33

we talked f2f, issue created

@noamnelke noamnelke merged commit 4d76569 into develop Apr 7, 2019
@y0sher y0sher deleted the block_oracle_improvements branch June 25, 2019 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants