Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hare vrf eligibility #834

Merged
merged 11 commits into from Apr 18, 2019
Merged

Hare vrf eligibility #834

merged 11 commits into from Apr 18, 2019

Conversation

gavraz
Copy link
Contributor

@gavraz gavraz commented Apr 18, 2019 •
edited

  • (Anton) added identity store
  • Added hare vrf oracle and hare beacon

antonlerner
antonlerner reviewed Apr 18, 2019
View reviewed changes
activation/atxdb.go Outdated Show resolved Hide resolved
antonlerner
antonlerner reviewed Apr 18, 2019
View reviewed changes
cmd/node/node.go
@@ -294,7 +294,12 @@ func (app *SpacemeshApp) initServices(nodeID types.NodeId, swarm service.Service
}

//todo: put in config
atxdb := activation.NewActivationDb(atxdbstore, mdb, 1000)
iddbstore, err := database.NewLDBDatabase(dbStorepath+"ids", 0, 0)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we've already fixed this bug in our branch, but for better UT the DB should be received from whom ever calls this function, in case of UT you dont need persistent DB like LDB

@gavraz gavraz merged commit c50f602 into develop Apr 18, 2019
@y0sher y0sher deleted the hare_vrf_eligibility branch September 10, 2019 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@barakshani barakshani barakshani left review comments

@antonlerner antonlerner antonlerner approved these changes

@zalmen zalmen Awaiting requested review from zalmen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gavraz @antonlerner @barakshani