Discovery on udp #769
Merged
Discovery on udp #769
+485
−439
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antonlerner
reviewed
Apr 2, 2019
|
|
||
| if res == nil { | ||
| return node.EmptyNode, errors.New("no peers found in routing table") | ||
| } | ||
|
|
||
| if res[0].DhtID().Equals(dhtid) { | ||
| if res[0].PublicKey().String() == pubkey.String() { |
antonlerner
reviewed
Apr 2, 2019
p2p/dht/ping.go
Outdated
| } | ||
| } | ||
|
|
||
| func (p *discovery) pingerCallback(from net.Addr, pi *pb.Ping) error { |
There was a problem hiding this comment.
rename to a better name that describes what this function does
antonlerner
reviewed
Apr 2, 2019
p2p/dht/ping.go
Outdated
| } | ||
| var addr string | ||
|
|
||
| if spl := strings.Split(from.String(), ":"); len(spl) > 1 { |
antonlerner
reviewed
Apr 2, 2019
| findnode.ReqID = reqID[:] | ||
| findnode.Payload = payload | ||
| // get up to count nearest peers to nodeDhtId | ||
| results := p.table.InternalLookup(nodeID) |
There was a problem hiding this comment.
what about when results =0
antonlerner
reviewed
Apr 2, 2019
p2p/dht/dht.go
Outdated
|
|
||
| service service.Service | ||
| disc DiscoveryProtocol | ||
| //fnp *findNodeProtocol |
antonlerner
reviewed
Apr 2, 2019
p2p/swarm.go
Outdated
| @@ -307,11 +303,16 @@ func (s *swarm) sendMessageImpl(peerPubKey p2pcrypto.PublicKey, protocol string, | |||
| var peer node.Node | |||
| var conn net.Connection | |||
|
|
|||
| if peerPubKey.String() == s.lNode.PublicKey().String() { | |||
| panic("catch it") | |||
There was a problem hiding this comment.
consider removing this and returning the error
antonlerner
reviewed
Apr 2, 2019
| } | ||
|
|
||
| _, err := s.cPool.GetConnection(peer.Address(), peer.PublicKey()) | ||
| _, err = s.cPool.GetConnection(peer.Address(), peer.PublicKey()) |
There was a problem hiding this comment.
comment that get connection will attempt to reconnect
antonlerner
approved these changes
Apr 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.