Hare sig #795
Merged
Hare sig #795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
gavraz
commented
Apr 8, 2019
gavraz
commented
- Added new signer verifier
- Removed pub key from hare proto
- Fully replaced hare sig with public extraction
barakshani
reviewed
Apr 8, 2019
zalmen
reviewed
Apr 14, 2019
zalmen
reviewed
Apr 14, 2019
zalmen
suggested changes
Apr 14, 2019
signing/signer.go
Outdated
| if len(buff) < 32 { | ||
| return nil, errors.New("buffer too small") | ||
| } | ||
| return &EdSigner{privKey: buff, pubKey: buff[:32]}, nil |
There was a problem hiding this comment.
Ask @barakshani if there is any way to validate that the private key matches the public key
There was a problem hiding this comment.
I am not sure what is the context here, but if you hold the private key, you can always recompute the public key from it
There was a problem hiding this comment.
@barakshani 's solution is more elegant and efficient
zalmen
suggested changes
Apr 15, 2019
zalmen
approved these changes
Apr 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.