P2p gossip propagate once #809
Merged
+167
−261
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
y0sher
commented
Apr 14, 2019
p2p/gossip/protocol.go
Outdated
| relayQ: relayChan, | ||
| messageQ: make(chan protocolMessage, messageQBufferSize), | ||
| propagateQ: make(chan service.MessageValidation, propagateHandleBufferSize), | ||
| //invalidMessageQ: make(map[hash]bool), // todo : remember to drain this |
y0sher
commented
Apr 14, 2019
p2p/gossip/protocol.go
Outdated
| }() | ||
| return nil | ||
| } | ||
| return |
zalmen
suggested changes
Apr 15, 2019
p2p/gossip/protocol.go
Outdated
| p.Debug("sending message to peer %v, hash %d", p.pubkey, checksum) | ||
| err := p.net.SendMessage(p.pubkey, ProtocolName, msg) | ||
| if err != nil { | ||
| p.Log.Info("Gossip protocol failed to send msg (calcHash %d) to peer %v, first attempt. err=%v", checksum, p.pubkey, err) |
There was a problem hiding this comment.
This should be an Error, not info.
p2p/gossip/protocol.go
Outdated
| p.Log.Info("Gossip protocol failed to send msg (calcHash %d) to peer %v, second attempt. err=%v", checksum, p.pubkey, err) | ||
| return | ||
| } | ||
| p.Log.Info("Gossip protocol failed to send msg (calcHash %d) to peer %v, second attempt. err=%v", checksum, p.pubkey, err) |
p2p/gossip/protocol.go
Outdated
| for p := range prot.peers { | ||
| peer := prot.peers[p] | ||
| peer.send(data, h) // non blocking | ||
| for e := range exclude { |
There was a problem hiding this comment.
In which case do you expect seeing more than one sender?
There was a problem hiding this comment.
Currently, the only call to this method passes one sender
p2p/gossip/protocol.go
Outdated
| msg := &pb.ProtocolMessage{ | ||
| Metadata: header, | ||
| Payload: &pb.Payload{Data: &pb.Payload_Payload{payload}}, | ||
| } | ||
|
|
||
| prot.processMessage(msg) | ||
| prot.processMessage(prot.localNodePubkey, msg) // todo: pass sender |
| // message and will determine its validity, therefore we can return in such case as well | ||
| return | ||
| } | ||
| // todo : - maybe block this peer since he sends us old messages |
y0sher
force-pushed
the
p2p_gossip_propagateonce
branch
from
945641d to
985e669
Compare
…ght need to pass it to protocols and back to gossip in validation phase). - do not propagate old messages. (ever) - remove global invalid cache, since we'll never propagate twice even if valids - maybe remove gossip "invalid" reporting since we'll only propagate valid and won't save old. (we can keep it for future use.)
y0sher
force-pushed
the
p2p_gossip_propagateonce
branch
from
42eccb2 to
0e5da13
Compare
zalmen
approved these changes
Apr 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.